[Linux-fbdev-devel] Siemens sx1: merge framebuffer support

[James Simmons]

Can you post the framebufer driver to the framebuffer list. We like to do
peer review. Thank you :-)

Framebuffer support for Siemens SX1; this is second big patch. (Third
one will be mixer/sound support). Support is simple / pretty minimal,
but seems to work okay (and is somehow important for a cell phone :-).

Pushed to linux-omap. I guess you're planning to send the missing
Kconfig + Makefile patch for this?
Also, it would be better to use omap_mcbsp_xmit_word() or
omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as
it does not do any checking that it worked. The aic23 and tsc2101
audio in linux-omap tree in general has the same problem.
Regards,
Tony

Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX,
so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

[Komal Shah]

Post by James Simmons
Can you post the framebufer driver to the framebuffer list. We like to do
peer review. Thank you :-)

Framebuffer support for Siemens SX1; this is second big patch. (Third
one will be mixer/sound support). Support is simple / pretty minimal,
but seems to work okay (and is somehow important for a cell phone :-).

Pushed to linux-omap. I guess you're planning to send the missing
Kconfig + Makefile patch for this?
Also, it would be better to use omap_mcbsp_xmit_word() or
omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as
it does not do any checking that it worked. The aic23 and tsc2101
audio in linux-omap tree in general has the same problem.
Regards,
Tony

Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX,
so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ?
-

Again, framebuffer support patch is based on the omap framebuffer
driver, which is not yet submitted to upstream/fbdevel list. sx1
framebuffer support just fill up the hooks required by -omap fb driver
framework.

[Tony Lindgren]

Hi,

Post by Komal Shah

Post by James Simmons
Can you post the framebufer driver to the framebuffer list. We like to do
peer review. Thank you :-)

It would be nice to get the framebuffer integrated. I think it would be
best if Imre submitted the patches as it's mostly his work.

Imre, do you have time to send the patches to framebuffer list? If not,
I can send them.

Post by Komal Shah

Post by James Simmons

Framebuffer support for Siemens SX1; this is second big patch. (Third
one will be mixer/sound support). Support is simple / pretty minimal,
but seems to work okay (and is somehow important for a cell phone

:-).

Pushed to linux-omap. I guess you're planning to send the missing
Kconfig + Makefile patch for this?
Also, it would be better to use omap_mcbsp_xmit_word() or
omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as
it does not do any checking that it worked. The aic23 and tsc2101
audio in linux-omap tree in general has the same problem.
Regards,
Tony

Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX,
so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ?
-

Again, framebuffer support patch is based on the omap framebuffer
driver, which is not yet submitted to upstream/fbdevel list. sx1
framebuffer support just fill up the hooks required by -omap fb driver
framework.

Yes, but the framebuffer code is in pretty much ready to be sent
upstream :)

Regards,

Tony

[Imre Deák]

Hi Tony and all,

Post by Tony Lindgren
Hi,

Post by Komal Shah

Post by James Simmons
Can you post the framebufer driver to the framebuffer list. We like to do
peer review. Thank you :-)

It would be nice to get the framebuffer integrated. I think it would be
best if Imre submitted the patches as it's mostly his work.
Imre, do you have time to send the patches to framebuffer list? If not,
I can send them.

Yes, I'm going to post it this week.

--Imre

Post by Tony Lindgren

Post by Komal Shah

Post by James Simmons

Framebuffer support for Siemens SX1; this is second big patch. (Third
one will be mixer/sound support). Support is simple / pretty minimal,
but seems to work okay (and is somehow important for a cell phone

:-).

Pushed to linux-omap. I guess you're planning to send the missing
Kconfig + Makefile patch for this?
Also, it would be better to use omap_mcbsp_xmit_word() or
omap_mcsbsp_spi_master_xmit_word_poll() instead of OMAP_MCBSP_WRITE as
it does not do any checking that it worked. The aic23 and tsc2101
audio in linux-omap tree in general has the same problem.
Regards,
Tony

Hmm. McBSP3 in SX1 is used in "GPIO mode". The only line used is CLKX,
so I think OMAP_MCBSP_WRITE would be enough. Am I wrong ?
-

Again, framebuffer support patch is based on the omap framebuffer
driver, which is not yet submitted to upstream/fbdevel list. sx1
framebuffer support just fill up the hooks required by -omap fb driver
framework.

Yes, but the framebuffer code is in pretty much ready to be sent
upstream :)
Regards,
Tony